On Thursday 10 of December 2009 21:34:53 Dave wrote: > Andrey Borzenkov wrote: > > I had to resurrect old notebook and immediately hit this under > > 2.6.32: > > > > [ 77.254109] WARNING: at > > /home/bor/src/linux-git/kernel/lockdep.c:2465 lockdep > > _trace_alloc+0x9a/0xa0() > > > > Until orinoco_lock can be converted from spinlock into mutex, this > > patch is the most simple solution. > > Thank you Andrey. The patch is correct (though it could clean up the > misdirected comment 4 or 5 lines above). > Do you want me to resubmit with this cleanup? > Is it worth pushing this to stable? > I think yes. Sleeping under spinlock with interrupts disabled is not fun even if it is very unlikely.
Attachment:
signature.asc
Description: This is a digitally signed message part.