Yes, getting rid of the spinlock around hw_host_to_card would mean that concurrent calls to hw_host_to_card could happen. I don't _think_ this would be a problem in if_spi, at least. Now that we've moved to using complete spi_message structures, each message should be sent atomically by the SPI layer. The only question is whether certain messages have to happen in sequence. For example, in if_spi_c2h_cmd, we do spu_read_u16 from scratch reg 2 to find out how many bytes to read. Then we read the bytes from the RDWRPORT register. If someone else did some other SPU operations between those two, would the module get confused? I don't _think_ so, but I haven't tested it. Colin On Tue, Dec 1, 2009 at 1:52 AM, Holger Schurig <holgerschurig@xxxxxxxxx> wrote: >> Perhaps the easiest thing would be to get rid of this usage of >> hw_host_to_card? > > That would mean to rewrite this not only for SPI, but also for > USB and CS. If you come up with patches, I'm willing to test this > against USB and/or CS, in case you don't have this hardware. > > -- > http://www.holgerschurig.de > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
