On Mon, Dec 7, 2009 at 3:51 AM, Kalle Valo <kalle.valo@xxxxxx> wrote: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > >> On Thu, 2009-12-03 at 12:25 -0800, Jason Young wrote: >> >>> The bit values for IEEE80211_WMM_IE_STA_SP_XXX are not correct. The Max SP >>> Length subfield settings table in 7.3.1.17 has the least significant bit listed >>> first. >>> >>> #define IEEE80211_WMM_IE_STA_SP_ALL (0<<5) >>> #define IEEE80211_WMM_IE_STA_SP_2 (1<<5) /* or (BIT(5)) */ >>> #define IEEE80211_WMM_IE_STA_SP_4 (2<<5) /* or (BIT(6)) */ >>> #define IEEE80211_WMM_IE_STA_SP_6 (3<<5) /* or (BIT(5) | BIT(6)) */ >> >> Can somebody clarify for me which part of this stuff is WMM, and which >> is "real" 802.11 QoS? Though this patch adds support for WMM Power Save, these defines will work for WMM and "real" 802.11 QoS. > I took a quick peek of the 802.11-2007 QoS part. My observation was > that the terms are the same, but that's about it. For example QoS Info > field is reversed, APSD capability is advertised through beacon > capability bits and naturally there are proper ids for IEs. The QoS info field itself is not reversed, the figure is just reversed. > So they are very similar but the frame handling has to be more or less > rewritten for 802.11 QoS. > > BTW, are there clients which support 802.11 QoS? Should we consider > adding it to mac80211, for example? Thoughts? > -- > Kalle Valo > Jason Young -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
