On Fri, 2009-11-27 at 17:40 +0800, Johannes Berg wrote: > You did the right thing in mac80211, but not here -- if it returns an > error it hasn't freed 'skb', only modified it. Indeed. > I think that we should have ieee80211_amsdu_to_8023s() consume it in > all cases, just not fill the list (and return an error I guess) when > it can't be decoded properly. Yeah, since I didn't even use it correctly myself, I couldn't expect others do. Besides, the nontransparent reuse of skb for the last item in the list (skb == rx->skb) looks dirty. I'll use RX_QUEUED in v3. Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
