Search Linux Wireless

Re: [PATCH] mac80211: annotate sleeping driver ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:

> On Sat, 2009-11-28 at 22:19 +0200, Kalle Valo wrote:
>> To make it easier to notice cases of calling sleeping ops in atomic context,
>> annotate driver-ops.h with appropiate might_sleep() calls. At the same time,
>> also document in mac80211.h the op functions with missing contexts.
>> 
>> mac80211 doesn't seem to use get_tx_stats anywhere currently. Just to be on
>> the safe side, I documented it to be atomic, but hopefully the op can be
>> removed in the future.
>> 
>> Compile-tested only.
>
> Nice, thanks. Haven't reviewed it in detail, but I'll trust you :)
>
> Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

Thanks for the trust! I'll, just in case, test the patch tomorrow both
with iwl3945 and wl1251 so that this trust doesn't backfire =)

But first some sleep.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux