Search Linux Wireless

Re: rfkill: persistent device suspend/resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 28 Nov 2009, Johannes Berg wrote:
> On Sat, 2009-11-28 at 11:27 -0200, Henrique de Moraes Holschuh wrote:
> > > static int rfkill_resume(struct device *dev)
> > > {
> > >         struct rfkill *rfkill = to_rfkill(dev);
> > >         bool cur;
> > > 
> > >         if (!rfkill->persistent) {
> > >                 cur = !!(rfkill->state & RFKILL_BLOCK_SW);
> > >                 rfkill_set_block(rfkill, cur);
> > >         }
> > 
> > The issue I am reporting is _only_ about persistent devices, so it is the
> > if(!rfkill->persistent) that is the problem.  It works perfectly for the
> > other devices.
> 
> So then I don't understand -- if the device specifically said that it
> was persistent, what kind of help does it need, and why does it not just
> unset persistent if it needs it?

Never mind, Alan gave me various good reasons for the code to remain as is,
and I will fix it in the driver in another way.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux