Search Linux Wireless

Re: [PATCH 06/12] wl1251: fix payload alignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:

> On Fri, 2009-11-27 at 13:08 +0200, Kalle Valo wrote:
>> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
>> 
>> > Eh, turn off the debugging option ...
>> 
>> Sure. But isn't this warning going to create false alarms for others?
>
> That's why it says "Say N unless you're writing a mac80211 based
> driver."

I was "writing a mac80211 based driver" so I enabled it, and it
tricked me =)

> Maybe it should say "Say N unless you want to debug potential
> alignment issues with your driver." Or maybe it should just go away
> now that we align things properly in mac80211, and most firmware
> either handles it or not, and there's nothing we can do about the
> firmware most of the time... And mesh makes it more complex anyway
> than the warning checks.

Maybe we should just remove it. Like you just said, there isn't much
we can do. I'll come up with a patch unless I get objections.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux