On Thu, 2009-11-26 at 18:05 +0800, Johannes Berg wrote: > Oh one more thing, can you make addr const? Sure. > Also -- you lost the extra TX headroom which I think mac80211 as an AP > requires since it could forward these frames? Or does that not happen? > Not sure right now why that was there to start with. Yes, I'd like to hear more feedback on this. I think it's a trade off between performance optimization and clean interface. As we already use dev_alloc_skb to reserve 32 bytes headroom, it should be enough for most of the current drivers. While for those drivers really need a bigger extra headroom and support Rx aggregation, this probably means ieee80211_skb_resize. But the resize should always happen for every packet from the IP stack, right? Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html