Search Linux Wireless

Re: [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-11-26 at 17:49 +0800, Johannes Berg wrote:
> > +     skb->dev = dev;
> > +     skb_queue_head_init(&frame_list);
> 
> ^ use __ versions please, no need for locking since it's on stack

You are right. Good catch!

> > +     dev->stats.rx_packets++;
> > +     dev->stats.rx_bytes += skb->len;
> 
> Shouldn't rx_packets be per sub-frame? 

Not very sure. Maybe it's one frame from the device's perspective? The
original code does this so I didn't change the behavior. Should I?

Thanks,
-yi

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux