> While at it might as well make this some configurable struct > which the drivers can add to the wiphy just as with the > subbands. Something like this? struct ieee80211_antenna lbs_antennas { u32 hwvalue; u32 flags; u32 capability; int max_gain; } static struct ieee80211_antenna lbs_antennas[] = { { .hwvalue = 0, .capability = IEEE80211_ANTENNA_RXTX, } }; wiphy->antennas = lbs_antennas; wiphy->n_anteanns = ARRAY_SIZE(lbs_antennas); Or should the antennas be added to "struct ieee80211_supported_band" instead of wiphy? Capabilities could be #define IEEE80211_ANTENNA_RX BIT(0) #define IEEE80211_ANTENNA_TX BIT(1) #define IEEE80211_ANTENNA_OMNI BIT(2) #define IEEE80211_ANTENNA_SECTIONAL BIT(3) #define IEEE80211_ANTENNA_RXTX (IEEE80211_ANTENNA_RX | IEEE80211_ANTENNA_TX) An unknown gain would be set to 0. > Not sure how to get this from other cards. Anyone know how > about on b43, iwlwifi, rallink? Libertas doesn't give this to you, AFAIK you can just get the number of antennas. > Not sure if allowing for ops for chainmask setting would also > be helpeful here, that would need some review. What is "chainmask setting", I don't even know the concept. You didn't give any comment on my mask idea for the user-space API. -- http://www.holgerschurig.de -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html