Search Linux Wireless

Re: [PATCH] rt2x00: Fix padding bug on L2PAD devices.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 24 November 2009, Gertjan van Wingerde wrote:
> While reviewing the l2pad function to align both the header and the payload
> on a DMA-capable boundary a bug was discovered where the payload would not
> be properly aligned. The header_align value was used where the payload_align
> value should have been used.
> 
> Signed-off-by: Gertjan van Wingerde <gwingerde@xxxxxxxxx>

Acked-by: Ivo van Doorn <IvDoorn@xxxxxxxxx>

> ---
>  drivers/net/wireless/rt2x00/rt2x00queue.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.c b/drivers/net/wireless/rt2x00/rt2x00queue.c
> index 32d4aea..239afc7 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00queue.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00queue.c
> @@ -214,7 +214,7 @@ void rt2x00queue_insert_l2pad(struct sk_buff *skb, unsigned int header_length)
>  		skb_push(skb, header_align);
>  		memmove(skb->data, skb->data + header_align, header_length);
>  		memmove(skb->data + header_length + l2pad,
> -			skb->data + header_length + l2pad + header_align,
> +			skb->data + header_length + l2pad + payload_align,
>  			frame_length - header_length);
>  		skbdesc->flags |= SKBDESC_L2_PADDED;
>  	}


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux