Dan Williams <dcbw@xxxxxxxxxx> writes: > On Fri, 2009-11-20 at 20:27 +0100, Christian Lamparter wrote: >> This (aggregated) patch adds a new sysfs file "eeprom_overwrite" >> which can be used to upload an customized eeprom image to the >> driver during normal operation. [...] > Honestly I wonder if this would be better done with ethtool. There's > already ethtool --eeprom-dump, would it be so hard to do an ethtool > --eeprom-load ? > > I can see a number of devices doing this, so in my mind it makes sense > to have a generic facility for this sort of thing. But then again it's > not so common an operation and its fraught with danger :) I think that devices without eeprom at all (eg. stlc4550, most wl1251 and all wl1271 chips) request_firmware() and a udev script is the best way to go, as they will need the eeprom data from user space during every boot. This was discussed few months back, but unfortunately I have yet to seen an implementation of this :) Hopefully I find some time to try this soon. But for devices with eeprom, having support in ethtool sounds good to me. > Libertas could potentially use this, but libertas has *two* EEPROM > images that it might need to update. So if ethtool did grow > --eeprom-load we may want to account for more than one eeprom image. Makes sense to mee. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
