Search Linux Wireless

[PATCH] mac80211: fix rcu locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Add a missing rcu_read_unlock() before jumping out
of the ieee80211_change_station() function in the
error case.

Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
---
*points finger at*

  commit fed1557d868e3a15b8a10700f79353e1f362e3a1
  Author: Felix Fietkau <nbd@xxxxxxxxxxx>
  Date:   Tue Nov 10 20:10:05 2009 +0100

      mac80211: implement support for 4-address frames for AP and client mode

 net/mac80211/cfg.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- wireless-testing.orig/net/mac80211/cfg.c	2009-11-20 10:04:21.000000000 +0100
+++ wireless-testing/net/mac80211/cfg.c	2009-11-20 10:04:37.000000000 +0100
@@ -818,8 +818,10 @@ static int ieee80211_change_station(stru
 		}
 
 		if (params->vlan->ieee80211_ptr->use_4addr) {
-			if (vlansdata->u.vlan.sta)
+			if (vlansdata->u.vlan.sta) {
+				rcu_read_unlock();
 				return -EBUSY;
+			}
 
 			rcu_assign_pointer(vlansdata->u.vlan.sta, sta);
 		}


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux