On Thu, 2009-11-19 at 23:30 +0100, Gertjan van Wingerde wrote: > >> - if (tx_info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS) > >> + if (!(skbdesc_flags & SKBDESC_NOT_MAC80211)) > >> ieee80211_tx_status_irqsafe(rt2x00dev->hw, entry->skb); > >> else > >> dev_kfree_skb_irq(entry->skb); > > > > I'm slightly confused here. Shouldn't both the tx_info->flags and skbdesc_flags be checked here? > > Now we run in the situation where tx_status is report even if mac80211 didn't ask for it. > > > > Never mind. I missed the change from "requested" to "required" for the > IEEE80211_TX_CTL_REQ_TX_STATUS flag. In fact, it wouldn't matter if you gave it a TX status for the RTS or CTS frame either, but it might be somewhat confusing :) The "required" is also not really correct. The frame could always be dropped elsewhere due to memory pressure or whatever... I'll need to reword that and explain much more. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
