On Wed, Nov 18, 2009 at 7:14 PM, John W. Linville
<linville@xxxxxxxxxxxxx> wrote:
> On Wed, Nov 18, 2009 at 11:53:51AM +0100, Johannes Berg wrote:
>> On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
>>
>> > ---
>> > include/linux/rfkill.h | 2 ++
>> > net/rfkill/core.c | 2 ++
>> > 2 files changed, 4 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> > index 3392c59..7ae75ef 100644
>> > --- a/include/linux/rfkill.h
>> > +++ b/include/linux/rfkill.h
>> > @@ -35,6 +35,7 @@
>> > * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
>> > * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> > * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> > + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
>> > * @NUM_RFKILL_TYPES: number of defined rfkill types
>> > */
>> > enum rfkill_type {
>> > @@ -44,6 +45,7 @@ enum rfkill_type {
>> > RFKILL_TYPE_UWB,
>> > RFKILL_TYPE_WIMAX,
>> > RFKILL_TYPE_WWAN,
>> > + RFKILL_TYPE_FM,
>> > RFKILL_TYPE_GPS,
>> > NUM_RFKILL_TYPES,
>> > };
>>
>> Nice try, but no fly. This struct is ABI, you cannot add in the middle.
>
> Ah, good point -- I think I may have inadvertently encourage this
> order. :-(
>
> It looks like you'll need the other order -- be mindful of the
> BUILD_BUG_ON I pointed-out in the previous email!
>
> John
>
> P.S. Hmmm...anyone want to add a kerneldoc entry for RFKILL_TYPE_GPS?
Can i add this ???
> --
> John W. Linville Someday the world will need a hero, and you
> linville@xxxxxxxxxxxxx might be all we have. Be ready.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
