On Sat, Nov 14, 2009 at 3:13 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote:
> On Fri, Nov 13, 2009 at 4:20 AM, Matteo Croce <technoboy85@xxxxxxxxx> wrote:
>> On Fri, Nov 13, 2009 at 12:27 PM, <Lorenzo.Bianconi83@xxxxxxxxx> wrote:
>>> Il giorno , Lorenzo Bianconi <lorenzo.bianconi83@xxxxxxxxx> ha scritto:
>>>> 2009/11/13 Johannes Berg johannes@xxxxxxxxxxxxxxxx>:
>>>> Yes, I tested ath5k/mac80211 and ath9k/mac80211 and both show the same
>>>> problem
>>>>
>>>> whereas madwifi/net80211, tested with the same module, has not memory
>>>> leak.
>>>>
>>>
>>> Hi all,
>>>
>>> I found a way to stop the mem leak. In the ath_tx_complete() function I have
>>> noticed that the struct tx_info_priv is not freed. I have made the following
>>> changes and now the memory remains stable. I do not know if this is the
>>> right place to put the kfree(tx_info_priv), however this seems to solve the
>>> issue.
>>>
>>> Cheers,
>>>
>>> Lorenzo
>>>
>>> @@ -1825,9 +1825,10 @@
>>> SC_OP_WAIT_FOR_TX_ACK));
>>> }
>>>
>>> - if (frame_type == ATH9K_NOT_INTERNAL)
>>> + if (frame_type == ATH9K_NOT_INTERNAL) {
>>> ieee80211_tx_status(hw, skb);
>>> - else
>>> + kfree(tx_info_priv);
>>> + } else
>>> ath9k_tx_status(hw, skb);
>>> }
>>
>> That's great. I'll try the fix with ath5k too
>
> Can you guys try Felix's RFC patches ? It removes this completely.
>
> Luis
>
Yes they fix the leak
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
