Search Linux Wireless

Re: [RFC 1/2] mac80211: add private driver flags and ampdu length to tx info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, Nov 14, 2009 at 1:48 AM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote:
> Some drivers may want to store a few flags of their own in the tx
> info. Also it is useful for 11n rate control to know the total number
> of aggregated frames in an AMPDU, not just the ones that were acked.
> Use two previously unused padding bytes to store those two values
>
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
> ---
>
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -386,6 +386,7 @@ struct ieee80211_tx_rate {
>  * @flags: transmit info flags, defined above
>  * @band: the band to transmit on (use for checking for races)
>  * @antenna_sel_tx: antenna to use, 0 for automatic diversity
> + * @driver_flags: flags for internal driver use
>  * @pad: padding, ignore
>  * @control: union for control data
>  * @status: union for status data
> @@ -404,7 +405,8 @@ struct ieee80211_tx_info {
>        u8 antenna_sel_tx;
>
>        /* 2 byte hole */
> -       u8 pad[2];
> +       u8 driver_flags;
> +       u8 ampdu_len;
>
>        union {
>                struct {

You have missed something in the comment above the structure,
you've added the fields "driver_flags" and "ampdu_len" in the structure and
removed the "pad" field. But in the comment you only add "driver_flags" and
kept the "pad" field.

Thanks,

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux