On Wed, Nov 11, 2009 at 12:14:39AM +0100, Johannes Berg wrote: > On Tue, 2009-11-10 at 23:03 +0000, Rui Paulo wrote: > > Hi John, > > > > On 10 Nov 2009, at 21:43, John W. Linville wrote: > > > In file included from net/wireless/lib80211.c:19: > > > include/linux/ieee80211.h:566: error: ‘ETH_ALEN’ undeclared here (not in a function) > > > > Hmm, I must've busted my testing procedure. I'm sorry. > > > > Anyway, I noticed that nothing uses ETH_ALEN in ieee80211.h and there > > are quite some places we could use it. Should we include if_ether.h in > > ieee80211.h (probably too evil) or should I just keep using 6 instead > > of ETH_ALEN ? > > When John mentioned this I remembered falling into that trap before .. > maybe better to just keep using 6, sorry! I don't much care either way. FWIW I would tend to prefer ETH_ALEN over 6, so long as it doesn't break the build... :-) John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
