Search Linux Wireless

Re: [PATCH] cfg80211: introduce nl80211_get_ifidx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 10 Nov 2009 12:51:43 +0100, Holger Schurig
<holgerschurig@xxxxxxxxxxxxxx> wrote:

> @@ -3182,20 +3182,11 @@
>  	int err;
>  
>  	if (!ifidx) {
> -		err = nlmsg_parse(cb->nlh, GENL_HDRLEN + nl80211_fam.hdrsize,
> -				  nl80211_fam.attrbuf, nl80211_fam.maxattr,
> -				  nl80211_policy);
> -		if (err)
> -			return err;
> -
> -		if (!nl80211_fam.attrbuf[NL80211_ATTR_IFINDEX])
> -			return -EINVAL;
> -
> -		ifidx = nla_get_u32(nl80211_fam.attrbuf[NL80211_ATTR_IFINDEX]);
> -		if (!ifidx)
> -			return -EINVAL;
> +		ifidx = nl80211_get_ifidx(cb);

do you need an:

 if(ifidx < 0)
    return ifidx;

here, as you assign it to cb->args[0], which differs from the original
behavior.

>  		cb->args[0] = ifidx;
>  	}
> +	if (ifidx < 0)
> +		return ifidx;
>  
>  	dev = dev_get_by_index(sock_net(skb->sk), ifidx);
>  	if (!dev)

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux