On Tue, 2009-11-10 at 11:17 +0100, Johannes Berg wrote: > Right now you're retrieving a single channel but can't even control > which one. Maybe that's useful functionality in addition to dump when > you _can_ ask for information on a specific channel, but that'd have to > pass in the frequency from userspace. > > Retrieving all data like you've implemented (though I guess you forgot > the multiple channels case) should be a dump. Maybe that's sufficient > since there won't be huge amounts of data and userspace can just pick > out what it needs from the dump. And maybe the get_survey() driver call can actually pass in the channel pointer ... then the drivers/mac80211 don't need to implement both get_survey() and dump_survey() since cfg80211 knows the valid channel list anyway. But that means iterating over the channel list all the time, even if the driver can only return values for a single channel. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part