Hi Kalle, > -----Original Message----- > From: Kalle Valo [mailto:kalle.valo@xxxxxxxxx] On Behalf Of Kalle Valo > Sent: Saturday, November 07, 2009 2:54 AM > To: Bing Zhao > Cc: John W. Linville; libertas-dev@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Amitkumar > Karwar > Subject: Re: [PATCH] Libertas: Fix issues while configuring host sleep > > Bing Zhao <bzhao@xxxxxxxxxxx> writes: > > >> The reformatting is a distraction. It would be better to do just > >> the fix part separately, especially if you are targetting 2.6.32. > > > > Without the reformatting, the change would be like this: > > > > + if (wol->wolopts == 0) criteria |= EHS_REMOVE_WAKEUP; > > > > But the "checkpatch.pl" script gave me an error on that: > > "ERROR: trailing statements should be on next line" > > You can do the reformatting in the first patch and the second patch > would contain the actual fix. I will re-submit as suggested. Thanks, Bing > > -- > Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
