On Mon, 2009-11-09 at 23:46 +0000, Rui Paulo wrote:
> +struct ieee80211_rann_ie {
> + u8 rann_flags;
> + u8 rann_hopcount;
> + u8 rann_ttl;
> + u8 rann_addr[6];
I'd prefer ETH_ALEN here, but it only changes the code, not the binary,
of course :)
> @@ -826,6 +827,7 @@ struct ieee802_11_elems {
> u8 preq_len;
> u8 prep_len;
> u8 perr_len;
> + u8 rann_len;
> u8 ch_switch_elem_len;
I suspect you can remove rann_len since it's fixed?
> + case MPATH_RANN:
> + mhwmp_dbg("sending RANN from %pM\n", orig_addr);
> + ie_len = 17;
The other two I wouldn't care too much about, but please use sizeof()
like you did when parsing the IEs.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
