On Sunday 08 November 2009 20:35:17 Ivo van Doorn wrote: > > > > > I think that they shouldn't have been added in the first place and I'll be > > > > > happy to add patch removing them to rt2800 tree (since code savings seem to > > > > > be really marginal and not worth the maintenance cost). > > > > > > > > Removing the ifdefs entirely would be fine. > > > > > > Like I said before -- this would mean driver's behavior change. Even though > > > WISOC code is currently dead (RALINK_RT288X and RALINK_RT305X are never set) > > > I prefer to not "overload" patches with logically different changes. > > > > > > If you feel strongly about it please fix it in rt2x00 code and rt2800 tree > > > will deal with it, or alternatively please send me an incremental patch. > > > > BTW the patch's impact is _320_ bytes increase of rt2800lib (on x86-64 so > > it is probably much less on the affected embedded architectures): > > > > text data bss dec hex filename > > before: > > 16916 0 0 16916 4214 drivers/net/wireless/rt2x00/rt2800lib.o > > after: > > 17281 0 0 17281 4381 drivers/net/wireless/rt2x00/rt2800lib.o > > > > for the _completely_ dead code (because embedded WISOC support is never > > enabled) that probably will be changed over anyway later during development. > > As mentioned: Wisoc is not dead code, it is there for the platform devices with Not in upstream, not in next, not in wireless, not in rt2x00... => Not our problem. ;) -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
