On Sunday 08 November 2009 20:25:48 Ivo van Doorn wrote: > > > > > The purpose of the defines was to keep the EFUSE code out of the driver > > > > > on embedded systems. So either rt2800lib should do the same with ifdefs > > > > > in the rt2800lib.c and rt2800lib.h files, or we don't need the efuse specific > > > > > wrappers in rt2800pci.c. > > > > > > > > Said wrappers predate all of my rt2800 patches. > > > > > > Actually the code inside the function was larger, since you removed multiple > > > lines from the function (moved to rt2800lib). But as said above, the wrapper > > > had the code inside the ifdef, while the this patch has the code outside the > > > ifdef, and thus the wrapper has no need. > > > > > > > I think that they shouldn't have been added in the first place and I'll be > > > > happy to add patch removing them to rt2800 tree (since code savings seem to > > > > be really marginal and not worth the maintenance cost). > > > > > > Removing the ifdefs entirely would be fine. > > > > Like I said before -- this would mean driver's behavior change. Even though > > WISOC code is currently dead (RALINK_RT288X and RALINK_RT305X are never set) > > I prefer to not "overload" patches with logically different changes. > > The code is not really dead. RALINK_RT288X and RALINK_RT305X are platforms which > are currently present in another tree, it is not the job for rt2x00 to set those defines. > I don't know when these platforms will be merged upstream, nor do I know the status of them. They are not really our problem then and said tree should maintain RALINK_RT[288X,305X] specific changes itself. :) > > If you feel strongly about it please fix it in rt2x00 code and rt2800 tree > > will deal with it, or alternatively please send me an incremental patch. > > Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx> Thanks, I'll merge it later to rt2800. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
