On 11/08/09 18:20, Bartlomiej Zolnierkiewicz wrote: > On Sunday 08 November 2009 13:38:34 Bartlomiej Zolnierkiewicz wrote: > >> On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote: >>> The rt2800pci driver is currently only marked as experimental, and only the help text explains that >>> the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot >>> enable this driver without knowing that it is broken. >>> >>> Signed-off-by: Gertjan van Wingerde <gwingerde@xxxxxxxxx> >> >>> @@ -78,9 +78,6 @@ config RT2800PCI >>> This adds support for rt2800 wireless chipset family. >>> Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052 >>> >>> - This driver is non-functional at the moment and is intended for >>> - developers. >>> - >>> When compiled as a module, this driver will be called "rt2800pci.ko". >>> >>> config RT2500USB >> >> This help text could have stayed, anyway.. >> >> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > > It turned out that CONFIG_BROKEN is no longer an user visible option so by > applying this change we would lose the advantage of having the upstream build > testing and early detection of breakages related to upstream API updates. > > [ I've just noticed now that rt2800pci was no longer included in the build > and dropped the patch from rt2800 tree. ] > Yeah, I noticed that too. So I guess it is better not to apply it, as we then loose testing coverage. --- Gertjan. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html