Search Linux Wireless

Re: [PATCH] mac80211 : fix a race with update_tkip_key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2009-11-07 at 19:10 +0100, gregor kowski wrote:

> >> +enum ieee80211_internal_tkip_initialized {
> >> +     TKIP_INITIALIZED_NONE,
> >> +     TKIP_INITIALIZED_PHASE1,
> >> +     TKIP_INITIALIZED_UPDATE_KEY,
> >> +};
> >
> > Those constants and the enum itself really need better names. This way,
> > there's no way to understand what it means without reading all the code.
> >
> Could you suggest better name ?
> 
> ieee80211_internal_tkip_state and
> TKIP_STATE_NOT_INIT
> TKIP_STATE_PHASE1_DONE
> TKIP_STATE_PHASE1_HW_UPLOADED

I, eh, ... have no idea :)

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux