On Friday 06 November 2009 22:42:07 John W. Linville wrote: > @@ -3379,7 +3378,7 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev, > priv = hw->priv; > priv->hw = hw; > priv->pdev = pdev; > - priv->device_info = (void *)id->driver_data; > + priv->device_info = &mwl8k_info_tbl[id->driver_data]; > priv->rxd_ops = priv->device_info->rxd_ops; > priv->sniffer_enabled = false; > priv->wmm_enabled = false; What about a sanity check for id->driver_data on the array range? Otherwise one could crash the kernel with sysfs/new_id by accident, as far as I can tell. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html