Larry Finger wrote:
On 11/04/2009 06:14 PM, Herton Ronaldo Krzesinski wrote:
Hi, I checked here and the code above in led_classdev_unregister is the same in
2.6.31, so I think the patch from Larry should also be applied/sent to 2.6.31.x
stable, as the bug could happen there too.
Herton,
Technically you are correct; however, I did extensive testing of
2.6.31 and _NEVER_ got the failure. The sequencing is a bug waiting to
happen, but something in the post 2.6.31 merge actually enabled the
bug to happen. I tried bisection to determine which change actully did
that, but was not successful.
Using kernel 2.6.29 and compat-wireless-stable 2.6.31* I am able to make
it flake. I may be the only one lucky enough to make this explode with
a high degree of accuracy but I can't see why we wouldn't fix what we
know is a bug waiting to happen. My vote is to add this patch to
2.6.31.x as well.
Thanks,
Rick Farina
My feeling is that stable can be left alone. Of course, if bug reports
of kernel panics on unload of rtl8187 start occurring, we will know
how to fix it.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
