On Mon, 2009-10-26 at 09:47 +0100, Holger Schurig wrote: > Hi, > > I'm a but confused about what fields in "struct > cfg80211_connect_params" (now abbreviated as sme->) > are relevant for me. > > > sme->private > ------------ > Right now, my lbs_cfg_connect() code just tests > sme->crypto.cipher_group. It doesn't check or use sme->privacy. > > and sme-> crypto.wpa_versions like they are redundant. Is this > correct? > > Empirical it migth be correct, because I can successfully connect > to APs, but if "privacy" is redundant, should I prepare a patch > to get rid of it? > > What is this? And how should my driver react to it's settings? > > > > sme->crypto.wpa_versions > ------------------------ > Again I seems to be ok to ignore this variable and just check > sme->crypto.cipher_group. In practice this seems to work, but is > it correct? > > What is this, what is the intented use of it? May I prepare a > patch to get rid of it? Wouldn't this be used to force WPA2/RSN? THere are APs out there where you can select WPA+CCMP and WPA2+TKIP, which wouldn't be apparent from just cipher_group, right? If userspace really does want you to only connect to a WPA2-capable AP and ignore WPA1+TKIP and WPA1+CCMP, then this field is the only way to indicate that. In libertas, this would all happen during the scan-before-connect when we try to find the BSSID of the AP we want to associate with. The WEXT stuff had a bunch of ugly checks to match up an AP in the scan list with the parameters of the connect request, and that's where I'd expect this to be used? Dan > > > sme->crypto.n_ciphers_pairwise, sme->crypto.ciphers_pairwise > ------------------------------------------------------------ > The same for sme->crypto.n_ciphers_pairwise. It is always 0 zero > for the WEP case and always 1 for the WPA/WPA2 case, so isn't it > redundant either? lbs_cfg_connect() ignores this, maybe it's > not needed at .connect() time anyway? > > But what is it really, what is the intended use? > > > > sme->crypto.n_akm_suites, sme->crypto.akm_suites > ------------------------------------------------ > In cfg80211.h, the kdoc help text for sme->crypo.akm_suites is > just "AKM suites" or "number of AKM suites", which keeps me as > confused as before. > > What is this? And how should my driver react to it's settings? > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
