Search Linux Wireless

Re: [PATCH] libertas: move mic failure event to wext.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> argh.  urgh.  This file (or files) need to lose this
> non-kernel-doc function notation.  Please.

Two things here:

* it's a copy and paste patch, so we move things just to another 
place. This makes the cfg80211-patch less intrusive and also 
makes the driver way smaller, once we don't compile WEXT in or 
get rid of WEXT altogether. Normally for copy-and-paste patches 
you shouldn't change other things.

* When I started with libertas, those comments where mostly 
useful for me. I didn't care for /** or @, as I just read the 
text. For me, those extra decorations have a less 
negative "touch". The "positive" effect of having comments at 
all did by far outweight the formatting.


For new code, I use a "normal" comment style, for example see 
http://marc.info/?l=linux-wireless&m=125569942616188&w=2

So, if the comment style really annoys you, you could submit a 
comment-reformat-patch.

-- 
http://www.holgerschurig.de
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux