Search Linux Wireless

Re: [PATCH] libertas: remove handling for CMD_802_11_LED_GPIO_CTRL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-10-19 at 13:31 +0200, Holger Schurig wrote:
> ... which just resided as an old-style command in cmd/cmdresp, but
> was nowhere useed. If we ever need it, we can re-add it as a newstyle
> command.

It's actually used by the OLPC folks; but right now there's simply no
mechanism to configure that ability via WEXT.  Is there some way to do
this via the kernel LED  framework instead that libertas should be
using?

Dan

> Signed-off-by: Holger Schurig <hs4233@xxxxxxxxxxxxxxxxxxxx>
> 
> --- linux-wl.orig/drivers/net/wireless/libertas/cmd.c
> +++ linux-wl/drivers/net/wireless/libertas/cmd.c
> @@ -1181,29 +1181,6 @@
>  
>  		ret = 0;
>  		break;
> -	case CMD_802_11_LED_GPIO_CTRL:
> -		{
> -			struct mrvl_ie_ledgpio *gpio =
> -			    (struct mrvl_ie_ledgpio*)
> -			    cmdptr->params.ledgpio.data;
> -
> -			memmove(&cmdptr->params.ledgpio,
> -				pdata_buf,
> -				sizeof(struct cmd_ds_802_11_led_ctrl));
> -
> -			cmdptr->command =
> -			    cpu_to_le16(CMD_802_11_LED_GPIO_CTRL);
> -
> -#define ACTION_NUMLED_TLVTYPE_LEN_FIELDS_LEN 8
> -			cmdptr->size =
> -			    cpu_to_le16(le16_to_cpu(gpio->header.len)
> -				+ S_DS_GEN
> -				+ ACTION_NUMLED_TLVTYPE_LEN_FIELDS_LEN);
> -			gpio->header.len = gpio->header.len;
> -
> -			ret = 0;
> -			break;
> -		}
>  
>  	case CMD_BT_ACCESS:
>  		ret = lbs_cmd_bt_access(cmdptr, cmd_action, pdata_buf);
> --- linux-wl.orig/drivers/net/wireless/libertas/cmdresp.c
> +++ linux-wl/drivers/net/wireless/libertas/cmdresp.c
> @@ -187,12 +187,6 @@
>  			sizeof(struct cmd_ds_802_11_tpc_cfg));
>  		spin_unlock_irqrestore(&priv->driver_lock, flags);
>  		break;
> -	case CMD_RET(CMD_802_11_LED_GPIO_CTRL):
> -		spin_lock_irqsave(&priv->driver_lock, flags);
> -		memmove((void *)priv->cur_cmd->callback_arg, &resp->params.ledgpio,
> -			sizeof(struct cmd_ds_802_11_led_ctrl));
> -		spin_unlock_irqrestore(&priv->driver_lock, flags);
> -		break;
>  
>  	case CMD_RET(CMD_GET_TSF):
>  		spin_lock_irqsave(&priv->driver_lock, flags);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux