On Sun, Oct 18, 2009 at 01:54, Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote: > Now to the less happy part.. > > I also used the opportunity to take a closer look at this driver and > it seems that it needlessly adds around 2 KLOC to kernel by duplicating > the common content of rt2800usb.h to rt2800pci.h instead of moving it > to the shared header (like it is done in the staging crap drivers): > > $ wc -l drivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2800pci.h > 1951 drivers/net/wireless/rt2x00/rt2800usb.h > 1960 drivers/net/wireless/rt2x00/rt2800pci.h > 3911 total > > $ diff -u drivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2800pci.h|diffstat > rt2800pci.h | 213 +++++++++++++++++++++++++++++++----------------------------- > 1 file changed, 111 insertions(+), 102 deletions(-) > > Similarly it looks like most of the code between rt2800usb.c and rt2800pci.c > could also be shared (up to another 2 KLOC saved) by adding abstraction layer > for accessing chipset registers over different buses (again like it is done > in staging crap drivers): > > $ wc -l drivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800pci.c > 3077 drivers/net/wireless/rt2x00/rt2800usb.c > 3323 drivers/net/wireless/rt2x00/rt2800pci.c > 6400 total > > $ diff -u drivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800pci.c|diffstat > rt2800pci.c | 2190 +++++++++++++++++++++++++++++++++--------------------------- > 1 file changed, 1218 insertions(+), 972 deletions(-) Nobody else has said it, so: Patches welcome! Your points with the vendor drivers apply here too - consolidating the common parts of the drivers will enhance readability, and make development easier, and mean that, with your help, these might get to a everyday usable state quicker. And remember that this is a preliminary release of the code. There's still a long way to go. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
