On Saturday 17 October 2009 17:08:24 Johannes Berg wrote: > On Sat, 2009-10-17 at 16:54 +0200, Bartlomiej Zolnierkiewicz wrote: > > > I also used the opportunity to take a closer look at this driver and > > it seems that it needlessly adds around 2 KLOC to kernel by duplicating > > the common content of rt2800usb.h to rt2800pci.h instead of moving it > > to the shared header (like it is done in the staging crap drivers): > > Tell me you're kidding -- comparing 2k duplicated LOC with a driver that > ships its own wifi stack? Why would I be? 1) The patch is submitted to kernel _proper_ not kernel staging so I see no excuse for duplicating 2-4 KLOC and it should be fixed. 2) The fact that the some staging driver consists in 90% of crap doesn't mean that it doesn't have some good design ideas.. (i.e. abstracting chipset registers access in a discussed case) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
