Hi John,
> > > From: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> > >
> > > By setting the WSC profile flag, we now support WPS as an enrollee.
> > >
> > > Signed-off-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Zhu Yi <yi.zhu@xxxxxxxxx>
> > > ---
> > > drivers/net/wireless/iwmc3200wifi/cfg80211.c | 7 +++++++
> > > drivers/net/wireless/iwmc3200wifi/commands.h | 3 +++
> > > 2 files changed, 10 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/net/wireless/iwmc3200wifi/cfg80211.c b/drivers/net/wireless/iwmc3200wifi/cfg80211.c
> > > index 0d2e719..a6d2f20 100644
> > > --- a/drivers/net/wireless/iwmc3200wifi/cfg80211.c
> > > +++ b/drivers/net/wireless/iwmc3200wifi/cfg80211.c
> > > @@ -628,6 +628,13 @@ static int iwm_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
> > > iwm->default_key = sme->key_idx;
> > > }
> > >
> > > + /* WPA and open AUTH type from wpa_s means WPS (a.k.a. WSC) */
> > > + if ((iwm->umac_profile->sec.flags &
> > > + (UMAC_SEC_FLG_WPA_ON_MSK | UMAC_SEC_FLG_RSNA_ON_MSK)) &&
> > > + iwm->umac_profile->sec.auth_type == UMAC_AUTH_TYPE_OPEN) {
> > > + iwm->umac_profile->sec.flags = UMAC_SEC_FLG_WSC_ON_MSK;
> > > + }
> > > +
> >
> > I don't wanna be picky, but what coding style are you following here?
> > The indentation makes no sense and doesn't improve readability.
>
> Given the length and complication of the conditions, the indentation
> seems fine to me. How would you do it?
it is double indentation of iwm->umac_profile... and (UMAC... and
iwm->uwm_profile are not even on the same vertical. If I stare long
enough at it, I can see a certain reasoning for it, but it is an ugly
block. Some extra macros might make this more readable. However if you
are fine with it, then that is good enough. I just mentioned it, because
I read the if clause wrongly when reviewing the patches.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
