On Tue, Oct 13, 2009 at 05:18:04PM -0700, Luis R. Rodriguez wrote: > On Tue, Oct 13, 2009 at 5:12 PM, Hin-Tak Leung <hintak.leung@xxxxxxxxx> wrote: > > On Tue, Oct 13, 2009 at 10:12 PM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote: > > > >> The condition #if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)) was > >> added recently because without it openSuse with kernel 2.6.27 will not > >> compile. OpenSuse backports the tracepoint part into their 2.6.27 kernel. > > > > I remember that thread now. It is probably wrong as a matter of policy > > to incorporate patches for distro kernels with backport bits through. > > - I am not saying you shouldn't be helpful and provide them - after > > all, more users == better testing, and no doubt the investigation > > itself throws more insights on the detailed mechanisms - but it is > > just that compat-wireless probably should not try to support arbitrary > > and substantial changes from a vanilla kernel. I know Suse is popular > > so it is important to support Suse users, but I am wondering if > > distro-specific changes should be separate or at least, clearly > > documented. > > Not sure why opensuse added round_jiffies_up() to their 2.6.27 > kernels, greg may know better, but since its only once change I'm > willing to live with what we did to resolve for it. We added that to the SLE 11 kernel as it was requred for a bunch of block layer backports to resolve a number of issues that we needed to do. Hope this helps explain things, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html