On Sun Oct 11 2009 10:31:42 GMT-0500 (CDT), Larry Finger wrote: > On 10/11/2009 09:28 AM, Quintin Pitts wrote: >> Hi, >> >> Sorry for my lack of experience in all aspects - first time >> submitting!!! > > Everyone that goes through this "right of passage" gets somewhat > discouraged by the response. My advice is to hang in. > > My first advice is for you to run every submitted patch through the > check at scripts/checkpatch.pl. This one shows 95 errors and 7 > warnings in 136 lines. Most of the errors are due to "DOS line > endings". We really hate carriage returns - a really useless occupier > of space unless it is _NOT_ followed by \n! Thanks for the advice! > As I understand it, this patch is to fix the driver to work around > firmware errors. If that is correct, please state that clearly. If > only partially correct, then indicate which parts are to fix firmware > errors, and which are to fix driver errors. Has your analysis included > thinking about where the driver might delay to avoid firmware problems. I think Christian has hit the nail on the head. Mostly flaky hardware or implementation (it8152 pci bridge) when pushed. > > I will let Christian comment more on the technical merits of the patch > as he understands the device much better than I do. > > Larry Thanks, Quintin. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
