Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
>> > + local_bh_disable();
>> > ieee80211_rx(dev->wl->hw, skb);
>> > + local_bh_enable();
>>
>> This is a bit awkward from drivers' point of view, we have to add the
>> same code to all mac80211 drivers using either SPI or SDIO buses.
>>
>> What about adding a new inline function ieee80211_rx_ni() which would
>> disable bottom halves like above and call ieee80211_rx()? IMHO that's
>> easier for the driver developers to understand and also easier to
>> document ("use this function when calling from process context"). If
>> this is acceptable, I can create a patch.
>
> I really don't see the point, since it's just three lines of code, but I
> wouldn't mind all that much either.
My worry are the developers who even don't know what is a bottom half
and might get it all wrong. (Yes, there really are such people.)
But if you don't see any benefit from adding a new function, I'll drop
the idea. No need to complicate this anymore :)
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
