On Thu, Oct 8, 2009 at 2:26 PM, Bob Copeland <me@xxxxxxxxxxxxxxx> wrote:
> On Tue, Oct 6, 2009 at 8:44 PM, Luis R. Rodriguez
> <lrodriguez@xxxxxxxxxxx> wrote:
>> @@ -3226,6 +3225,14 @@ static void ath5k_bss_info_changed(struct ieee80211_hw *hw,
>> set_beacon_filter(hw, sc->assoc);
>> ath5k_hw_set_ledstate(sc->ah, sc->assoc ?
>> AR5K_LED_ASSOC : AR5K_LED_INIT);
>> + if (bss_conf->assoc) {
>> + ATH5K_DBG(sc, ATH5K_DEBUG_ANY,
>> + "Bss Info ASSOC %d, bssid: %pM\n",
>> + bss_conf->aid, common->curbssid);
>> + common->curaid = bss_conf->aid;
>> + ath5k_hw_set_associd(ah);
>> + /* Once ANI is available you would start it here */
>> + }
>
> Just quick question - do we only want to call this if we are associated?
>
> Or maybe we should call it to reset the mask if we are unassociated...
>
> I wrote a patch a while ago to the ath5k list that did something similar,
> but I did:
>
> if (changes & (BSS_CHANGED_BSSID | BSS_CHANGED_ASSOC)) {
> ath5k_hw_set_associd(ah, ah->ah_bssid, ah->ah_aid);
> }
>
> Thus if it changed regardless of the reason why, we update the mask.
Yeah might be a good idea to do it that way -- although upon disassoc
you should also just disable ps.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
