On Thursday 08 October 2009 00:43:36 Larry Finger wrote: > Johannes Berg wrote: > > This is because when stopping polling we need to cancel the work and > > sync on it, but when starting it's completely async so starting can be > > in any context. > > Does that mean that start could be moved outside the mutex_lock so > that the start and stop would look symmetrical in b43? I think it's already complicated enough what's safe in b43 to do outside of the locks. Let's not complicate it further. The simple rule is: Do it locked. The only exception really are syncing functions which sync for code holding the same lock. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
