On Tue, 2009-10-06 at 16:48 +0200, Stanislaw Gruszka wrote:
> > The text format isn't all that useful, but the binary
> > format can also be obtained easily via debugfs and
> > then analysed on the fly or offline with debugging
> > tools.
>
> What particular tool is most useful here (Yes, I didn't read
> Documentation/trace yet) ?
None really yet. Maybe trace-cmd.
> Shouldn't we also remove or at least rewrite IWL_DEBUG_{IO,TX,RX}
> to simplify things and remove double functionality ?
Maybe. But right now people are probably still using the printk
debugging.
> > +EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_ioread32);
> > +EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_iowrite32);
> > +EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_rx);
>
> Missed EXPORT_TRACEPOINT_SYMBOL(iwlwif_dev_tx) ?
No.
> Beside, shouldn't we have two trace point - one when sending data to device
> second when getting ACK in rx queue ?
Could be useful at some point, I guess. Besides, tracepoints can be
added at will.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
