On Sun, Oct 4, 2009 at 10:52 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > From: Rafael J. Wysocki <rjw@xxxxxxx> > > Simplify the suspend and resume callbacks of ath5k by converting the > driver to struct dev_pm_ops and allowing the PCI PM core to do the > PCI-specific suspend/resume handling. > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> Do you happen to know if the new dev_pm_ops thing handle WOL / WoW [1]? [1] http://wireless.kernel.org/en/users/Documentation/WoW > #ifdef CONFIG_PM > -static int > -ath5k_pci_suspend(struct pci_dev *pdev, pm_message_t state) > +static int ath5k_pci_suspend(struct device *dev) > { > - struct ieee80211_hw *hw = pci_get_drvdata(pdev); > + struct ieee80211_hw *hw = pci_get_drvdata(to_pci_dev(dev)); > struct ath5k_softc *sc = hw->priv; > > ath5k_led_off(sc); > - > - pci_save_state(pdev); > - pci_disable_device(pdev); For WoW right here we'd do pci_prepare_to_sleep(pdev) and bail out. > - pci_set_power_state(pdev, PCI_D3hot); And here we'd call something like this: pci_wake_from_d3(pdev, !!sc->wow_triggers_enabled); > - > return 0; > } Are all drivers being converted? It'll be a while before we get WoW enabled on ath5k but it is technically possible, the work was tested for ath9k back in July [2] but I never submitted this to be merged due to some inconsistent issues I was noticing with the hardware. [2] http://kernel.org/pub/linux/kernel/people/mcgrof/patches/wow-07-21.patch Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
