On Fri, Oct 02, 2009 at 09:38:02PM +0200, Michael Buesch wrote:
> On Friday 02 October 2009 21:30:43 Andrew Price wrote:
> > Hi,
> >
> > I'm seeing this warning when I unplug my wireless card while the
> > network interface is still up. It doesn't seem to cause any permanent
> > damage - when I plug it back in I can use the wireless card again.
> >
> > I'm using today's mainline kernel as of 0efe5e32 with Michael Buesch's
> > "b43: Don't use struct wldev after detach" patch added, though I don't
> > believe that patch is the culprit because the warning triggers without
> > it too.
> >
> > The line it refers to is:
> > B43_WARN_ON(b43_read32(dev, B43_MMIO_GEN_IRQ_MASK));
>
> This should fix it
It does indeed,
Tested-by: Andrew Price <andy@xxxxxxxxxxxxxxxxx>
(for this and the "b43: Don't use struct wldev after detach" patch).
Thanks.
>
> ---
> drivers/net/wireless/b43/main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -3874,6 +3874,7 @@ static struct b43_wldev * b43_wireless_c
> {
> struct b43_wl *wl = dev->wl;
> struct b43_wldev *orig_dev;
> + u32 mask;
>
> redo:
> if (!dev || b43_status(dev) < B43_STAT_STARTED)
> @@ -3920,7 +3921,8 @@ redo:
> goto redo;
> return dev;
> }
> - B43_WARN_ON(b43_read32(dev, B43_MMIO_GEN_IRQ_MASK));
> + mask = b43_read32(dev, B43_MMIO_GEN_IRQ_MASK);
> + B43_WARN_ON(mask != 0xFFFFFFFF && mask);
>
> /* Drain the TX queue */
> while (skb_queue_len(&wl->tx_queue))
>
>
>
> --
> Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
