On Wed, 2009-09-30 at 21:19 -0400, John W. Linville wrote: [...] > + len = sizeof(wiphy->fw_version); > + snprintf(wiphy->fw_version, len, "%d.%d.%d-%d", > + priv->fw_version.major, priv->fw_version.minor, > + priv->fw_version.patch, priv->fw_version.build); > + /* null terminate the strings in case they were truncated */ > + wiphy->fw_version[len - 1] = '\0'; [...] This last statement is unnecessary; snprintf() always null-terminates (unless the length is zero). Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
