On Thu, Sep 24, 2009 at 02:38:07PM -0700, reinette chatre wrote: > Hi Stanislaw, > > On Wed, 2009-09-23 at 01:51 -0700, Stanislaw Gruszka wrote: > > In some cases firmware can give us bad value of index in transmit > > buffers array. This patch add sanity check for such values and return > > from processing function instantly when it happens. > > > > https://bugzilla.redhat.com/show_bug.cgi?id=521931 > > > > Patch was tested by reporter on iwl5000. I think check can be also > > helpful for 4965. > > > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > --- > > I looked at the bugzilla entry and I think that there may be another fix > required here. After the driver submitted the five frames it received a > surprisingly large number of tx responses from firmware, with one of > these causing the problem. The bad value from the firmware may be a > result of something else done incorrectly by driver here since the > firmware has been trying for more than 40 times at this point to inform > driver about tx results. > > I commented in that bugzilla and we can continue to debug this issue > there. Until then I'd like to hold off on this patch. Hmmm...well, I already sent it to Dave/Linus -- it's in 2.6.32-rc1... John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html