On Sun, 2009-09-27 at 21:58 +0100, Hugh Dickins wrote: > This 2/2 patch does indeed work: many thanks. But... ... it won't fix anything by itself. > > This should fix the regression Hugh reported (of course requires the > > other patch which unfortunately I forgot to CC you, Hugh, I'll send you > > a copy in private). > > ... the 1/2 patch has a couple of problems. > > The trivial problem is that include/linux/notifier.h in Linus's git has > #define NETDEV_PRE_UP 0x000D > #define NETDEV_BONDING_OLDTYPE 0x000E > #define NETDEV_BONDING_NEWTYPE 0x000F > > So it rejects the patch you posted: I changed it to add > #define NETDEV_PRE_INIT 0x0010 > just after the NETDEV_BONDING_NEWTYPE line. Right, that's fixable, I was evidently working against the wrong tree. > The more serious problem is that it stops both my machines from booting, > too early for framebuffer to show any messages, but vga=normal shows a > long stacktrace scrolling offscreen, with some notifier stuff in there. Ahrg. That's strange. > I've experimented by moving your NETDEV_PRE_INIT hunk later in the > sequence, just before the netdev_initialize_kobject(dev) (so I also > changed the "goto out" to "goto err_uninit"): both* machines then boot > correctly, and this mail leaves me wirelessly. > > I'll now experiment to see how early I can move that hunk. Interesting. Thanks for that; must be some notifier that doesn't expect to be run. For all I care, it can be right before the kobject stuff, so maybe that makes more sense as it's a fairly last-minute fix now. Of course then it should be POST_INIT or PRE_REGISTER I suppose. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
