On Thu, Sep 24, 2009 at 09:11:36PM +0100, Alan Jenkins wrote: > Gábor Stefanik wrote: > > On Thu, Sep 24, 2009 at 9:15 PM, Alan Jenkins > > <alan-jenkins@xxxxxxxxxxxxxx> wrote: > > ... > >> @@ -1108,6 +1110,10 @@ static int sony_nc_setup_rfkill(struct acpi_device *device, > >> if (!rfk) > >> return -ENOMEM; > >> > >> + sony_call_snc_handle(0x124, 0x200, &result); > >> > > > > Please define these somewhere, don't use magic numbers. > > > > The rfkill functions are all together in the file, it's not that bad. > But ok. > > There's another bug / missing feature - it doesn't re-read the hard > states on resume from suspend. > > I'll submit two more patches then. I won't convert all of the magic > numbers though. This isn't hardware I know anything about, and "magic > numbers" is a good description of some of them - right and the whole purpose of them is to hit specific code paths in the DSDT tables. Not sure we would benefit that much from having names for them. -- mattia :wq! -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
