On Thu, Sep 24, 2009 at 11:02 AM, Kalle Valo <kalle.valo@xxxxxx> wrote: > From: Kalle Valo <kalle.valo@xxxxxxxxx> > > It's useful to provide firmware and hardware version to user space and have a > generic interface to retrieve them. Users can provide the version information > in bug reports etc. > > Add fields for firmware and hardware version to struct wiphy and return > them to user space in NL80211_CMD_GET_WIPHY reply. Wow that was quick :) > Signed-off-by: Kalle Valo <kalle.valo@xxxxxxxxx> > --- > > include/linux/nl80211.h | 3 +++ > include/net/cfg80211.h | 5 +++++ > net/wireless/nl80211.c | 11 +++++++++++ > 3 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h > index a8d71ed..6d6651f 100644 > --- a/include/linux/nl80211.h > +++ b/include/linux/nl80211.h > @@ -714,6 +714,9 @@ enum nl80211_attrs { > > NL80211_ATTR_PID, > > + NL80211_ATTR_FW_VERSION, > + NL80211_ATTR_HW_VERSION, > + Some kdoc on this would be nice. > /* add attributes here, update the policy in nl80211.c */ > > __NL80211_ATTR_AFTER_LAST, > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index 3d874c6..de3da19 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -1070,6 +1070,8 @@ struct cfg80211_ops { > * and registration/helper functions > */ > > +#define CFG80211_VERSION_LEN 32 Probably best to just remove this or at least make this not just CFG80211_VERSION_LEN, seems like this is related to cfg80211's version somehow. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html