On Tue, Sep 08, 2009 at 11:32:37PM -0400, Bob Copeland wrote: > On Tue, Sep 08, 2009 at 09:52:31PM -0300, Thadeu Lima de Souza Cascardo wrote: > > ath5k will try to request irq when resuming and fails if the device > > (like a PCMCIA card) has been removed. > > That's not true, ath5k no longer requests an irq when resuming. > I've just saw there's a commit by you in the next tree that just removes the irq requesting and releasing in resume/suspend functions. > > This solves this issue defining a new flag for the status bitmap to > > indicate when irq has been successfully requested and does not try to > > release it if not. > > I'd rather not fix it with a status bit. What kernel is this against? > This is against v2.6.31-rc9, so I get a warning with a version that's about to get stable. Sorry I am late in the release cycle. I've used a status bit because the drivers I took a look at did release/request irq in suspend/resume. I couldn't find a message about not doing it was the right thing which I thought I saw in the latest updates to v2.6.31-rcX. I guess it was something just like your commit which I did see some weeks ago. Since this is warning, is this worth backporting to rc? > -- > Bob Copeland %% www.bobcopeland.com > Regards, Cascardo.
Attachment:
signature.asc
Description: Digital signature
