On Wed, 2009-09-02 at 10:38 -0700, Andrew Lutomirski wrote: > On Wed, Sep 2, 2009 at 1:30 PM, Johannes Berg<johannes@xxxxxxxxxxxxxxxx> wrote: > > > > I was under the impression that Andrew said this actually didn't work. > > Exactly. My patch fixes that, although there might be a better way to do that. Seems to be in iwl_power_update_mode() the mode is forced to CAM if power save disabled, and power save is set to disabled if mac considers it disabled (see setting of power_disabled in iwl_mac_config()). One way around this is to always allow user to set power mode, even if it is disabled from mac perspective. Since the power mode is updated in many more spots (not always triggered by user) I do not know the full implications of this change. Considering the unknown of this change and the problems we have encountered when enabling power save I would rather not merge such a patch without significant testing. I think it is too late for 2.6.31. The same problem should not exist in 2.6.32. Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
