On Thu, Aug 27, 2009 at 8:01 PM, Nick Kossifidis<mickflemm@xxxxxxxxx> wrote: > 2009/8/27 Luis R. Rodriguez <mcgrof@xxxxxxxxx>: >> On Thu, Aug 27, 2009 at 11:17 AM, Bob Copeland<bcopeland@xxxxxxxxx> wrote: >>> On Thu, Aug 27, 2009 at 8:58 AM, Nick Kossifidis<mickflemm@xxxxxxxxx> wrote: >>>> 2009/8/27 Pavel Roskin <proski@xxxxxxx>: >>> >>>> Current code works fine (i 've checked it against various cards), >>>> there is nothing wrong >>>> with having another function for reading turbo modes, i find it's >>>> cleaner that way. >>> >>> Well, we also don't use the turbo modes at all and that's where the >>> error is (IIRC) so it shouldn't have any impact. :) >> >> Again, why don't we just remove all that fucking turbo cruft? >> >> Luis >> > > Why should we remove it, we are discussing on implementing channel > width setting for 5 and 10 MHz channels already so where is the > problem supporting turbo mode (40MHz) ? Supporting 5 MHz and 10 MHz channels is very different than supporting Turbo (40 MHz). 5 MHz and 10 MHz channels seems to be something you can use as per 802.11, 40 MHz "Turbo" stuff is just a vendor extension and at least by my part I don't want to move a finger to either support it nor do I think its a good idea to support it. Other people have objected to vendor extensions before on mac80211 so I don't think you'll find much support for this from a lot of people. The way I see is if you want vendor extensions like Atheros Turbo or XR use MadWifi. > Also EEPROM code should read the eeprom and fill the structs, since > these infos are there we should read them, i don't see any reason to > skip them I didn't see Bob's patch remove that stuff. Its pointless to use it though. > i thought our goal was to support this hw as much as > possible, We should support users as best as possible, whether or not you support vendor extensions is an entirely different story. > if we want to get rid of MadWiFi we 'll have to at least > support 5, 10 and 40MHz (turbo) channels. I don't want to get rid of MadWifi, what we have now is a proper upstream replacement. MadWifi is still a hack put together, and people who want hacks can use that. > I understand that there is > no support yet on mac80211/cfg80211 but i don't think removing all > this stuff and bring it back is the right thing to do. I don't expect it will come back. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
